This is me... There's nothing remotely exciting about the changes. Of late, when I file "issues" before making PRs like this, people tend to use AIs to write PRs to fix my issues...
For some repositories, I'd make annotations explaining why I made changes, but this repository seems to want as _little_ text as possible, so I'm not going to comment on it in the PR unless people have questions/requests.
Note that I did correct items in the changelog -- I understand they're copied from pull request/issue descriptions, but some processing is done already (…), and if people object, I can trivially drop such changes.
There's one notable directory rename (`platfrom` to `platform`)
Matvey Kukuy (archestra team) —
I'm not sure how we could merge this one as it modifies practically every file and could break so many things
Josh Soref —
Happy to split it in any particular way you like
Josh Soref —
if your system is mostly by top level directory, i can split by that
Josh Soref —
(i don't have a lot of time today, and won't have more time before Sunday, but I'm in no hurry)
Matvey Kukuy (archestra team) —
@user you wanted to comment 😉
Ildar Iskhakov (archestra team) —
Hi, thank you for fixing all the grammar mistakes😊
Would be much easier to merge if we split code changes from the docs🙏
Josh Soref —
is that something i can distinguish by file extension or path? (i have ~2 hr before next week)
Josh Soref —
I'll try a simple split of `platform/` vs `docs/` + `README.md`
Josh Soref —
github.com/archestra-ai/archestra/pull/4938
Josh Soref —
@user is that split enough? The original PR no longer includes the docs changes.
Matvey Kukuy (archestra team) —
@user
Ildar Iskhakov (archestra team) —
thank you! Merged!
Matvey Kukuy (archestra team) —
🔥
Josh Soref —
Do you want me to look through the other PR for things? Each commit in a PR is a specific change, so if a certain category is undesirable, I can drop it. I generally check to see if an unhyphenated word is used before suggesting it (and I skip flavors that aren't used). I can, of course, skip changelogs...
Hey @user; that gate is repo-wide right now, prolly not specific to you (@user is hitting the same wall above). For a fix that's already scoped against #3511 & addresses iskhakov's #3726 feedback, your fork and a Slack note (like the one you just posted) pointing to the diff is probably the right path under the current posture. Worth a careful read of [contributing.md](https://github.com/archestra-ai/archestra/blob/main/docs/pages/contributing.md) before posting anything substantive ... the "Contribute Responsibly" section is actively enforced. Short/specific should probably land better than long/structured, as the latter gets read as slop regardless of your effort in the matter. I'm a friendly community member without any skin in the game, but I'm happy to welcome you, and I genuinely wish you good luck! (FWIW @user same spam-filtering gate affecting you too it seems.)
This is me... There's nothing remotely exciting about the changes. Of late, when I file "issues" before making PRs like this, people tend to use AIs to write PRs to fix my issues...
This is me... There's nothing remotely exciting about the changes. Of late, when I file "issues" before making PRs like this, people tend to use AIs to write PRs to fix my issues...
For some repositories, I'd make annotations explaining why I made changes, but this repository seems to want as little text as possible, so I'm not going to comment on it in the PR unless people have questions/requests.
Note that I did correct items in the changelog -- I understand they're copied from pull request/issue descriptions, but some processing is done already (…), and if people object, I can trivially drop such changes.
There's one notable directory rename (platfrom to platform)
Do you want me to look through the other PR for things? Each commit in a PR is a specific change, so if a certain category is undesirable, I can drop it. I generally check to see if an unhyphenated word is used before suggesting it (and I skip flavors that aren't used). I can, of course, skip changelogs...