Thread

JS
Josh Soref2:27 PMOpen in Slack
This is me... There's nothing remotely exciting about the changes. Of late, when I file "issues" before making PRs like this, people tend to use AIs to write PRs to fix my issues...

15 replies
JS
Josh Soref2:44 PMOpen in Slack
For some repositories, I'd make annotations explaining why I made changes, but this repository seems to want as little text as possible, so I'm not going to comment on it in the PR unless people have questions/requests.
Note that I did correct items in the changelog -- I understand they're copied from pull request/issue descriptions, but some processing is done already (…), and if people object, I can trivially drop such changes.
There's one notable directory rename (platfrom to platform)
MK
Matvey Kukuy (archestra team)3:00 PMOpen in Slack
I'm not sure how we could merge this one as it modifies practically every file and could break so many things
JS
Josh Soref3:00 PMOpen in Slack
Happy to split it in any particular way you like
JS
Josh Soref3:01 PMOpen in Slack
if your system is mostly by top level directory, i can split by that
JS
Josh Soref3:01 PMOpen in Slack
(i don't have a lot of time today, and won't have more time before Sunday, but I'm in no hurry)
MK
Matvey Kukuy (archestra team)5:23 PMOpen in Slack
@user you wanted to comment 😉
II
Ildar Iskhakov (archestra team)6:33 PMOpen in Slack
Hi, thank you for fixing all the grammar mistakes😊
Would be much easier to merge if we split code changes from the docs🙏
JS
Josh Soref6:34 PMOpen in Slack
is that something i can distinguish by file extension or path? (i have ~2 hr before next week)
JS
Josh Soref6:39 PMOpen in Slack
I'll try a simple split of platform/ vs docs/ + README.md
JS
Josh Soref12:09 PMOpen in Slack
@user is that split enough? The original PR no longer includes the docs changes.
MK
Matvey Kukuy (archestra team)7:39 AMOpen in Slack
@user
II
Ildar Iskhakov (archestra team)7:40 AMOpen in Slack
thank you! Merged!
MK
Matvey Kukuy (archestra team)8:36 AMOpen in Slack
🔥
JS
Josh Soref12:48 PMOpen in Slack
Do you want me to look through the other PR for things? Each commit in a PR is a specific change, so if a certain category is undesirable, I can drop it. I generally check to see if an unhyphenated word is used before suggesting it (and I skip flavors that aren't used). I can, of course, skip changelogs...